[HttpClient] Fix handling timeouts when responses are destructed #42896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
|
Merge conflicts with 5.3 should be solved using #42894 |
nicolas-grekas
force-pushed
the
hc-timeout44
branch
from
8d2c718
to
c95deea
Compare
|
Hey! I think @Toflar has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 11, 2021
… requests (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Don't reset timeout counter when initializing requests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #44544 | License | MIT | Doc PR | - Same as #42896 but on initialize. Commits ------- 8f3bdeb [HttpClient] Don't reset timeout counter when initializing requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while giving a workshop on HttpClient at WebSummerCamp:
When responses are destructed, the timeout is counted from the call to the destructor. This means that when 10 concurrent requests are destructed and they all timeout, the code waits for
10 * $timeoutbefore giving back control.This PR fixes it by counting the timeouts from the first timeout when they happen in chain on destruction.