Fix framework configuration when messenger uses without console #43202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upyx
changed the title
This was referenced Sep 27, 2021
upyx
force-pushed
the
fix-reset-on-message
branch
from
cd89b0b
to
7589f3d
Compare
|
can you fix fabbot issue? |
|
I've added a test for messenger without console. I wrapped |
upyx
force-pushed
the
fix-reset-on-message
branch
from
04b115a
to
39861be
Compare
|
@lyrixx 👋 I'd love to finish the work which we started :) Could you check it, please? |
This was referenced Sep 28, 2021
fabpot
approved these changes
Sep 29, 2021
|
Thank you @upyx. |
fabpot
force-pushed
the
fix-reset-on-message
branch
from
39861be
to
d098ef8
Compare
fabpot
added a commit
that referenced
this pull request
Nov 8, 2021
…nfig option default to true (upyx) This PR was merged into the 6.0 branch. Discussion ---------- [FrameworkBundle] Make the messenger.reset_on_message config option default to true | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no It changes the "framework.messenger.reset_on_message" configuration option to true and changes deprecation warnings. ~It's waiting fixes from #43202~ Commits ------- e3eecd1 [FrameworkBundle] Make the messenger.reset_on_message config option default to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hurried, an addition to #43133
It fixes #43133 (review)
It adds the forgotten CHANGELOG & UPGRADE
I'm not sure about the CHANGELOG format. I've done as people do but... it says "New entries must be added on top of the list." However, nobody does it 🤷
I don't know how to test the fix, because ofclass_exists()call that cannot be easily mocked.src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php:245: