[Lock] Use platform to identify the PDO driver

[Jean85]

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #43048
License	MIT

This should fix the issue in the same way we did for #42011. I'm not sure if I should add/change any test...

[jderusse]

This PR revert what have been done in 7eca3a5#diff-98857ac5bb047b333495db5092ea4b875924022056c5b5522d7ecb224fac5f6f

@nicolas-grekas do you remember why you changed this in a merge commit?

[jderusse]

Regarding the @derrabus comment, this PR brings nothing but introduce a future deprecation for upcoming Doctrine 3.2

I'm 👎 for this change

edit: this PR fixes the issue referenced in the description

[stof]

@jderusse this PR fixes compatibility with driver decorators (inspecting the driver class to find the target platform is a mistake). See the ticket referenced in the issue description, which describes precisely such a bug.

[jderusse]

@jderusse this PR fixes compatibility with driver decorators (inspecting the driver class to find the target platform is a mistake). See the ticket referenced in the issue description, which describes precisely such a bug.

Still.. getName will be removed in the next major version (doctrine/dbal#4763) fixing the issue by introducing a dependency with a (soon) deprecated method is not the right way to fix the issue IMHO.

[chalasr]

I agree, seems worth trying to fix this using instanceof checks on the platform instance instead so we don't have to revisit this too soon.

[Jean85]

I've changed the approach to use the instanceof on the platforms.

[derrabus]

Thank you @Jean85.