[Lock] Split PdoStore into DoctrineDbalStore #43332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
GromNaN
commented
Oct 6, 2021
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
from
7e5c686
to
70d9543
Compare
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
from
70d9543
to
54d687b
Compare
stof
reviewed
Oct 6, 2021
|
I think, we can simplify
This should allow us to remove all DBAL-related code from |
|
Oh, and thank you very much for working on this topic! |
derrabus
reviewed
Oct 6, 2021
derrabus
reviewed
Oct 6, 2021
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
2 times, most recently
from
39bcf0c
to
7922f8b
Compare
derrabus
reviewed
Oct 6, 2021
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
from
7922f8b
to
e1b3c34
Compare
stof
reviewed
Oct 6, 2021
GromNaN
changed the title
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
3 times, most recently
from
6a80a44
to
f7d493a
Compare
derrabus
requested changes
Oct 7, 2021
src/Symfony/Component/Lock/Store/DoctrineDbalPostgreSqlStore.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
2 times, most recently
from
952ca0e
to
af32763
Compare
GromNaN
force-pushed
the
dbal/lock-pdo-5.4
branch
from
af32763
to
53f84af
Compare
|
Can you take a look at the failing tests? |
|
Thank you @GromNaN. |
fabpot
force-pushed
the
dbal/lock-pdo-5.4
branch
from
14d99b6
to
6dcaae1
Compare
This was referenced Nov 5, 2021
Merged
Merged
This is actually a regression. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2023
…able + add tests (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][HttpFoundation][Lock] Fix PDO store not creating table + add tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Unlike e.g. SQLite, PostgreSQL doesn't throw an exception on `$conn->prepare()` if the table is missing, it instead throws it on `$stmt->execute()`, so the table never gets created. The table used to get created, but the behavior was broken with #43332. Commits ------- cb5d832 [Cache][Lock] Fix PDO store not creating table + add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
DoctrineDbalStoreandDoctrineDbalPostgreSqlStore.Doctrine\DBAL\Connectionor<driver>://DSN inPdoStoreorPostgreSqlStoreis deprecated in 5.4 and will be removed in 6.0. UseDoctrineDbalStoreorDoctrineDbalPostgreSqlStoreinstead.DoctrineDbalStore(thanks to numerical params)DoctrineDbalStoreorDoctrineDbalPostgreSqlStoreis instanced, instead of the first usage of the connection.