Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] SymfonyStyle enhancements #43595

Merged
merged 1 commit into from Oct 20, 2021
Merged

[Console] SymfonyStyle enhancements #43595

merged 1 commit into from Oct 20, 2021

Conversation

kbond
Copy link
Member

@kbond kbond commented Oct 19, 2021 •
edited

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR todo

Adds the following enhancements to SymfonyStyle:

  1. Add ::progressIterate()
  2. Add ::createTable() method to reduce duplication and add customization point
  3. Use ConsoleSectionOutput when creating table (if available) - allows for creating "appendable" tables

@kbond kbond requested a review from chalasr as a code owner October 19, 2021 17:40
@carsonbot carsonbot added this to the 5.4 milestone Oct 19, 2021
@kbond kbond changed the title [Console] SymfonyStyle improvements [Console] SymfonyStyle enhancements Oct 19, 2021
@kbond kbond force-pushed the symfony-style-update branch 3 times, most recently from d4af349 to e420814 Compare October 19, 2021 18:18
@chalasr
Copy link
Member

chalasr commented Oct 19, 2021

Looks good, thanks. Can you add some test ?

@chalasr chalasr added this to Wouter's (@wouterj) in Help Wanted Oct 19, 2021
@kbond
Copy link
Member Author

kbond commented Oct 20, 2021

Tests added.

@fabpot
Copy link
Member

fabpot commented Oct 20, 2021

Thank you @kbond.

@fabpot fabpot mentioned this pull request Oct 20, 2021
Closed
@fabpot fabpot merged commit 1fdd7a8 into symfony:5.4 Oct 20, 2021
@kbond kbond deleted the symfony-style-update branch October 20, 2021 15:32
@kbond kbond mentioned this pull request Oct 21, 2021
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 30, 2021
@javiereguiluz
minor symfony#15975 [Console] Document SymfonyStyle additions (kbond)
b871d8e 
This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Document `SymfonyStyle` additions

Docs for symfony/symfony#43595.

Fixes symfony#15969.

Commits
-------

2d2f035 document SymfonyStyle additions
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
Help Wanted
Wouter's (@wouterj)
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbond @chalasr @fabpot @carsonbot