[HttpClient] Implement ResetInterface for all http clients #43985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,6 +134,13 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| }); | |||
| } | |||
|
|
|||
| public function reset() | |||
There was a problem hiding this comment.
I'd suggest moving the implementation to DecoratorTrait
There was a problem hiding this comment.
agree, makes more sense. Will do changes...
rmikalkenas
force-pushed
the
reset-interface
branch
from
4651eaa
to
ab53683
Compare
fabpot
approved these changes
Nov 10, 2021
|
Thank you @rmikalkenas. |
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of discussion at #43972
Targeting 5.4 branch as I think its kind of a new feature without BC break