Reuse TranslationTrait instead of copy-pasting code #44449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Koc
commented
Dec 3, 2021
Koc
commented
| Q | A |
|---|---|
| Branch? | 6.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
Koc
force-pushed
the
feature/reuse-translations-trait
branch
from
9e87ea6
to
efd5174
Compare
|
failures looks like unrelated |
stof
reviewed
Dec 3, 2021
| @@ -42,6 +42,8 @@ | |||
| #[AsCommand(name: 'translation:extract', description: 'Extract missing translations keys from code to translation files.')] | |||
| class TranslationUpdateCommand extends Command | |||
| { | |||
| use TranslationTrait; | |||
There was a problem hiding this comment.
depending on an internal trait of another bundle looks like a bad idea. It would force us to stop using semver constraints in the composer.json, as the trait is not covered by semver (and so changing it in Symfony 6.2 might break FrameworkBundle 6.1)
|
Closing based on the comment from @stof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.