Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] AnnotationDirectoryLoader::load() may return null #45263

Merged
merged 1 commit into from Jan 31, 2022

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Jan 31, 2022

Closes #45259.

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45259
License MIT

@carsonbot carsonbot added this to the 6.1 milestone Jan 31, 2022
@mhujer mhujer changed the base branch from 6.1 to 6.0 January 31, 2022 19:42
@derrabus
Copy link
Member

Good catch, thanks @mhujer.

@derrabus derrabus merged commit d54ef8c into symfony:6.0 Jan 31, 2022
@mhujer mhujer deleted the ticket-45259 branch February 1, 2022 08:28
@trsteel88
Copy link
Contributor

@derrabus any chance of a patch version being tagged? I'm keen to launch a project on Symfony 6.0 and this is holding me up.

@trsteel88
Copy link
Contributor

Actually, I've found a temporary workaround:

exclude: '../../src/Controller/**/AbstractController.php'

@derrabus
Copy link
Member

derrabus commented Feb 3, 2022

We usually do releases by the end of the month. This patch will be part of the 6.0.5 release. Until then, please use the following constraint in your composer.json to get this patch:

"require": {
    "symfony/routing": "~6.0.5@dev"
}

@trsteel88
Copy link
Contributor

No worries. Thanks for the quick response.

@fabpot fabpot mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnotationDirectoryLoader raises type error for abstract classes
5 participants