Stand with Ukraine

[fabpot]

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	n/a

On 4.4

On 5.4

[nicolas-grekas]

👍 with one suggestion and one test to fix before merging. Thanks!

[yunmoxue]

It's a bad pr. It breaks the development experience.
why did it on this?

[derrabus]

It breaks the development experience.

Please elaborate.

[kevinpapst]

I wanted to check how the result of this PR looks like in my SF 4.4 application (Console v4.4.37) and it seems the OutputFormatterStyle does not allow arbitrary colors.

PHPStorm Console (Mac, zsh):

Replacing the colors with yellow and blue would work:

[yunmoxue]

It breaks the development experience.

Please elaborate.

@derrabus
Code is pure, clean, simple. There should be no political positions.
There is one time, will be countless times.
Today it could be Ukraine, tomorrow could be CN, US, GB or other.

I don't mean to be rude, but seeing “stand with Ukraine” will make me unhappy, beacause the symfony is the greate framework in my heart, i don’t want it to be a political tool.

but sadly, and your ceo looks very glad to do it.
look symfony-cli/symfony-cli@d09ad2d

[fabpot]

My mistake, I created the PR on 5.4 first, then backported it to 4.4. Will fix it before the merge of course.

[williamdes]

It breaks the development experience.

Please elaborate.

@derrabus Code is pure, clean, simple. There should be no political positions. There is one time, will be countless times. Today it could be Ukraine, tomorrow could be CN, US, GB or other.

I don't mean to be rude, but seeing “stand with Ukraine” will make me unhappy, beacause the symfony is the greate framework in my heart, i don’t want it to be a political tool.

but sadly, and your ceo looks very glad to do it. look symfony-cli/symfony-cli@d09ad2d

I agree too, in my opinion code should not spread any political position.
That said if tools want to add some notice in places that do not affect any user directly (like packagist or phpunit did in the version lines) that's kind of okay.

[fabpot]

That said if tools want to add some notice in places that do not affect any user directly (like packagist or phpunit did in the version lines) that's kind of okay.

Which is exactly what we are doing here, right?

[yunmoxue]

That said if tools want to add some notice in places that do not affect any user directly (like packagist or phpunit did in the version lines) that's kind of okay.

Which is exactly what we are doing here, right?

I think you put your idea on the website is enough. There is no need to add it to the code.

even It's already affecting me to read the document, and not only me.

[williamdes]

That said if tools want to add some notice in places that do not affect any user directly (like packagist or phpunit did in the version lines) that's kind of okay.

Which is exactly what we are doing here, right?

Probably, this PR is missing a description screenshot as reading the code is not very clear how it will affect outputs ;)

[derrabus]

There should be no political positions.

Opposing a war is not a political position. Helping the victims of a war is not a political position.

[fabpot]

Screenshots were added for more clarity.

[yunmoxue]

There should be no political positions.

Opposing a war is not a political position. Helping the victims of a war is not a political position.

yes, i absolutely agree with you.

Uh....em... but, is not The Syrian and Iraq in the war?

i will never reply it, If you put the text "love and peace", "hope the world haven't war".

you stand with Ukraine , why don't stand with Syrian and Iraq or other country in the war together?

it's is why i say it is political position.

[derrabus]

Uh....em... but, is not The Syrian and Iraq in the war?

Please look up "whataboutism". I'm not taking that bait.

[nicolas-grekas]

I think open-source (and thus Symfony) is a by-product of global peace.
The war in Ukraine is a direct threat to global peace. This is what makes the situation there unique IMHO.
Being politically neutral doesn't mean not fighting for your roots when they are in danger.
And OSS is one of Symfony's root (just one very narrow example of those roots btw.)

👍 again on my side.

[yunmoxue]

Uh....em... but, is not The Syrian and Iraq in the war?

Please look up "whataboutism". I'm not taking that bait.

i searched and get the message.

"On February 24, there were 4 air strikes around the world: 1. The Israeli Air Force attacked the Syrian army. 2. The Saudi Air Force airstrikes Yemeni civilians. 3. The United States bombed Somalia. 4. Russia launches airstrikes on Ukrainian military installations. 4 air raids, the first 3 are little known, the 4th is well known;"

i don't stand any political position.
i don't think Russia is right.
i hate the war.
and i care the Ukraine people and any people under the war include the Russia civilian.

i just speaking my viewpoint on the code.

"don't put 'stand any country' on the code"

you can ignore if you think it is "bait".