[ErrorHandler][HttpKernel] Read SYMFONY_IDE to render exception in case of fatal error #45745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
GromNaN
force-pushed
the
symfony-ide-fatal
branch
from
04dc168
to
cc4a16d
Compare
|
Hey! I think @PhilETaylor has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
symfony-ide-fatal
branch
from
cc4a16d
to
b0211f5
Compare
nicolas-grekas
approved these changes
Mar 17, 2022
src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
symfony-ide-fatal
branch
2 times, most recently
from
97a24e1
to
c942cfe
Compare
src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php
Outdated
Show resolved
Hide resolved
GromNaN
force-pushed
the
symfony-ide-fatal
branch
from
c942cfe
to
03ad4af
Compare
Sorry, nothing to add here. My changes were in HtmlRenderer to render a custom template 2 years ago 6e1d16b and not related to framework.ide :) :) Although I use the framework.ide links daily so happy to test this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44575, the env var
SYMFONY_IDEis read whenframework.ideis not set. This works to format links in most runtime exceptions. But fatal errors that occurs before application boot are not rendered using this config (ex: syntax error in service class).Since the env var is globally available, it can be read even if it's not been injected.
The list of IDE formats have been duplicated from
FileLinkFormatter.The update of
Symfony\Component\HttpKernel\Debug\FileLinkFormatteris not necessary for my use-case, but for exhaustivity.