[RateLimiter] Fix rate serialization for long intervals (monthly and yearly) #45764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @alexandre-daubois has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
approved these changes
Mar 17, 2022
fabpot
approved these changes
Mar 18, 2022
|
Thank you @smelesh. |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2022
…onthly and yearly) (smelesh) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [RateLimiter] Fix rate serialization for long intervals (monthly and yearly) | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #... | License | MIT | Doc PR | no Long rate intervals (monthly and yearly) are serialized with incorrect ISO interval, so token bucket refills earlier than expected: - yearly interval acts as 100 days; - monthly interval acts as 10 days. Commits ------- 4810066 [RateLimiter] Fix rate serialization for long intervals (monthly and yearly)
fabpot
force-pushed
the
fix-rate-serialization
branch
from
a34cdba
to
4810066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long rate intervals (monthly and yearly) are serialized with incorrect ISO interval, so token bucket refills earlier than expected: