[DoctrineBridge] Add missing break #46713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
| @@ -200,6 +200,7 @@ public function getTypes($class, $property, array $context = []) | |||
| return [new Type(Type::BUILTIN_TYPE_ARRAY, $nullable, null, true, new Type(Type::BUILTIN_TYPE_INT), $enumType ?? new Type(Type::BUILTIN_TYPE_STRING))]; | |||
| } | |||
| case Type::BUILTIN_TYPE_INT: | |||
| // no break, because type int and string are handled the same way, if $enumType is set | |||
There was a problem hiding this comment.
I meant BEFORE this case, aka between line 201 and 202 :)
There was a problem hiding this comment.
Oh yeah, kinda obvious, sorry for the misunderstanding :)
I've changed the commit and added the missing break.
Sajito
changed the title
|
Thank you @Sajito. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only adds the "no break" comment as requested on my last PR:This PR only adds the missing break as requested on my last PR: #46676 (comment)
I hope it's fine to not include the describing table.
The missing break is on purpose, so here is no real code change.The missing break should not have caused any side effects.I have not changed any tests here, because both cases are already tested by these two lines:
symfony/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php
Lines 186 to 187 in 7fc7acb