[HttpKernel] Fix a PHP 8.1 deprecation notice in HttpCache #46769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jun 24, 2022
|
|
||
| return abs($entry->getTtl()) < $timeout; | ||
| return abs($ttl) < $timeout; |
There was a problem hiding this comment.
Suggested change
| return abs($ttl) < $timeout; | |
| return abs($entry->getTtl() ?: 0) < $timeout; |
There was a problem hiding this comment.
The suggestion looks good to me.
carsonbot
changed the title
|
Thank you @mpdude. |
This was referenced Jun 26, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 may trigger a deprecation notice
PHP Deprecated: abs(): Passing null to parameter #1 ($num) of type int|float is deprecated in .../symfony/http-kernel/HttpCache/HttpCache.php on line 721The reason is that
$entry->getTtl()may returnnullfor cache entries where no freshness information is present.I think we would err on the safe side by not using stale-while-revalidate behaviour in this case.