Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoctrineBridge] Fix auto mapping for bundles that contain only embeddables #47798

Merged
merged 1 commit into from Oct 9, 2022
Merged

[DoctrineBridge] Fix auto mapping for bundles that contain only embeddables #47798

merged 1 commit into from Oct 9, 2022

Conversation

jorissae
Copy link
Contributor

@jorissae jorissae commented Oct 6, 2022 •
edited by derrabus

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47791
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 5.4 milestone Oct 6, 2022
@derrabus
Copy link
Member

derrabus commented Oct 6, 2022

Would it be possible to cover this change with a test?

@derrabus derrabus changed the title fix issue #47791 auto mapping with bundle content only Embeddable Fix auto mapping for bundles that contain only embeddables Oct 6, 2022
@carsonbot carsonbot changed the title Fix auto mapping for bundles that contain only embeddables [DoctrineBridge] Fix auto mapping for bundles that contain only embeddables Oct 6, 2022
@derrabus
Copy link
Member

derrabus commented Oct 9, 2022

Thank you @jorissae.

@derrabus derrabus merged commit 25483b0 into symfony:5.4 Oct 9, 2022
This was referenced Oct 12, 2022
Merged
Merged
Merged
@derrabus derrabus mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jorissae @derrabus @stof @carsonbot