[DependencyInjection] Use WeakReference to break circular references in the container #48469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-weak-ref
branch
from
65d7233
to
315ae63
Compare
|
Rebase needed |
nicolas-grekas
force-pushed
the
di-weak-ref
branch
from
315ae63
to
11a279f
Compare
|
Rebased |
nicolas-grekas
force-pushed
the
di-weak-ref
branch
2 times, most recently
from
93d9b59
to
2f16657
Compare
|
Rebase needed again :) |
nicolas-grekas
force-pushed
the
di-weak-ref
branch
from
2f16657
to
a3b7fca
Compare
|
rebased (failures unrelated) |
|
Thank you @nicolas-grekas. |
stof
reviewed
Dec 9, 2022
nicolas-grekas
added a commit
that referenced
this pull request
Mar 14, 2023
…ilder (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Use weak references in ContainerBuilder | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same as #48469 for ContainerBuilder. Commits ------- 749d4b9 [DependencyInjection] Use weak references in ContainerBuilder
nicolas-grekas
added a commit
that referenced
this pull request
May 26, 2023
…ontainer" (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Revert "Use weak references in the container" | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50439 | License | MIT | Doc PR | - This is the second time this issue is reported, let's revert PR #48469 and #49684 before it does more harm :) Commits ------- d6ea474 [DependencyInjection] Revert "Use weak references in the container"
nicolas-grekas
added a commit
that referenced
this pull request
Jul 19, 2023
…ces multiple times with as files `true` (HypeMC) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Fix fetching lazy non-shared services multiple times with as files `true` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50975 | License | MIT | Doc PR | - Followup to #50985, fixes case when `as_files` is `true`. This particular problem exists only on v6.3 and was introduced in #48469. Commits ------- cb434a4 [DependencyInjection] Fix fetching lazy non-shared services multiple times with as files true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #48461, I realized that we could break many circular loops involving the container by using a
WeakReferenceto access it. This happens when we generate closures.Conceptually, we generate this at the moment:
And we'd generate this with this PR:
This should reduce the pressure on the garbage collector.