[CssSelector] add support for :is() and :where() #48803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
from
f2d4128
to
d1d438d
Compare
OskarStark
reviewed
Dec 30, 2022
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
2 times, most recently
from
d56aef3
to
b71d1b6
Compare
|
You should rebase instead of merging 6.3 |
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
2 times, most recently
from
8872ef6
to
26eefb3
Compare
|
My bad, I used the GitHub UI to resolve conflicts 🤦♂️ |
fabpot
requested changes
Dec 30, 2022
fancyweb
reviewed
Dec 30, 2022
fancyweb
reviewed
Jan 3, 2023
stof
requested changes
Jan 3, 2023
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
stof
requested changes
Jan 4, 2023
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
from
23ed186
to
f22bf69
Compare
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
3 times, most recently
from
4a39386
to
b262a86
Compare
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
from
b262a86
to
4b70ca5
Compare
|
@stof Reviews have been resolved. Is there anything to change ? |
Jean-Beru
force-pushed
the
css-selector/add-is-and-where
branch
from
4b70ca5
to
752f921
Compare
|
I rebased this PR to 6.4. Should I keep it opened ? |
stloyd
reviewed
Jul 28, 2023
fabpot
requested changes
Aug 1, 2023
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Feb 3, 2024
| @@ -1,6 +1,12 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 6.4 | |||
| @@ -1,6 +1,12 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 6.4 | |||
| ----- | |||
fabpot
force-pushed
the
css-selector/add-is-and-where
branch
from
c483f62
to
c083e1d
Compare
|
Thank you @Jean-Beru. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 5, 2024
…eru) This PR was submitted for the 6.4 branch but it was merged into the 7.1 branch instead. Discussion ---------- [CssSelector] add support for :is() and :where() Add documentation for * symfony/symfony#48803 Commits ------- f61c919 [CssSelector] add support for :is() and :where()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for :is() and :where() pseudo-classes.