[Security] Return default value instead of deferring to lower prio resolvers when using #[CurrentUser] and no user is found #49034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
force-pushed
the
patch-31
branch
2 times, most recently
from
3eb06be
to
8cfe338
Compare
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Jan 19, 2023
nicolas-grekas
force-pushed
the
patch-31
branch
from
8cfe338
to
38b00c7
Compare
…solvers when using #[CurrentUser] and no user is found
nicolas-grekas
force-pushed
the
patch-31
branch
from
38b00c7
to
abc5203
Compare
|
Thank you @Seldaek. |
8 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that if you have an action with
fooAction(string $email, #[CurrentUser] User $user = null)i.e. you want the current user if logged in but otherwise null, if there is no user logged in the EntityValueResolver gets called after UserValueResolver, and if you also have another param which would allow it to try to resolve a User it will do so as it is a mapped entity. But if it gives you a random user here instead of the logged user this is BAD :)