Mark DSNs as #[SensitiveParameter] #49065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 22, 2023
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Jan 22, 2023
GromNaN
reviewed
Jan 22, 2023
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/PdoSessionHandler.php
Outdated
Show resolved
Hide resolved
derrabus
approved these changes
Jan 23, 2023
stof
approved these changes
Jan 23, 2023
chalasr
approved these changes
Jan 23, 2023
nicolas-grekas
force-pushed
the
dsn-sensitive
branch
from
a27c87b
to
3f97cdb
Compare
GromNaN
approved these changes
Jan 23, 2023
OskarStark
approved these changes
Jan 23, 2023
nicolas-grekas
force-pushed
the
dsn-sensitive
branch
from
3f97cdb
to
849e575
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2023
This PR was merged into the 6.3 branch. Discussion ---------- Remove full DSNs from exception messages | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #49065 We should be careful when reviewing notifier bridges, to ensure that transports' `__toString()` don't embed any secrets. /cc `@OskarStark` Commits ------- 1cbd95e Remove full DSNs from exception messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.