[Security] deprecate the $secret argument of the PersistentRememberMeHandler constructor #49217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 3, 2023
•
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | #49103 (comment) |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
pr-49103
branch
3 times, most recently
from
9234bbf
to
e03fb8c
Compare
maxbeckers
reviewed
Feb 3, 2023
src/Symfony/Component/Security/Http/RememberMe/PersistentRememberMeHandler.php
Outdated
Show resolved
Hide resolved
chalasr
reviewed
Feb 5, 2023
src/Symfony/Component/Security/Http/RememberMe/PersistentRememberMeHandler.php
Outdated
Show resolved
Hide resolved
chalasr
previously approved these changes
Feb 5, 2023
chalasr
dismissed
their stale review
Looks like tests are broken with this change
fabpot
approved these changes
Apr 8, 2023
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.