[Messenger] Allow passing a string instead of an array in TransportNamesStamp
#49270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
DX
carsonbot
changed the title
TransportNamesStampTransportNamesStamp
chalasr
approved these changes
Feb 7, 2023
alexandre-daubois
force-pushed
the
dx-transports-name-stamp
branch
from
4c66768
to
591f1f4
Compare
|
You're right, entry added! |
maxbeckers
approved these changes
Feb 8, 2023
nicolas-grekas
force-pushed
the
dx-transports-name-stamp
branch
from
591f1f4
to
ff86922
Compare
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve a bit the DX when using
TransportNamesStampby allowing passing a string as the only argument of the stamp when only one transport is provided by the developer.Also, I fixed the property name to match getter's name. I did not changed constructor argument's name as I'm afraid it would be a BC if it is used with named arguments 🤔