New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator] Implement countUnit option for Length constraint #49464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, I just have minor comments.
src/Symfony/Component/Validator/Constraints/LengthValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/LengthTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/LengthTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Feb 21, 2023
src/Symfony/Component/Validator/Constraints/LengthValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Feb 21, 2023
Please rebase+squash to get rid of merge commits. |
Thank you @spackmat. |
Thanks @nicolas-grekas and @stof! I'll provide a PR for the docs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
countUnit
option for theLength
constraint as proposed and discussed in #49309. That allows to control which strlen-method is used to count the string length for theLength
constraint:Length::COUNT_BYTES
counts with\strlen()
Length::COUNT_CODEPOINTS
counts with\mb_strlen()
(default setting reflecting the former behavior)Length::COUNT_GRAPHEMES
counts with\grapheme_strlen()
(e.g. emojis count as 1)Also implements the corresponding tests.
Examples: