[FrameworkBundle] Workflow - Fix LogicException about a wrong configuration of "enabled" node

[adpauly]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	/
License	MIT
Doc PR	/

When I try to configure the YAML node "enabled" under a workflow configuration:

framework:
    workflows:
        order_approval_state:
            enabled: false # <--- HERE
            type: state_machine 
            supports: 
                - AppBundle\Entity\OrderApproval

The following exception is thrown:

//vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
if (isset($workflow['enabled']) && false === $workflow['enabled']) {
    throw new LogicException(sprintf('Cannot disable a single workflow. Remove the configuration for the workflow "%s" instead.', $workflow['name']));
}

But it actually throws the following PHP error:

In Configuration.php line 262:
                                 
  Notice: Undefined index: name  

I think we should use the $key variable instead of this undefined index.
$key contains the workflow name.

When changing, I get the attempted exception:

In Configuration.php line 262:
                                                                                                               
  Cannot disable a single workflow. Remove the configuration for the workflow "order_approval_state" instead.                                                                                                                                  

(I took a look in 6.2, it doesn't fix yet.)

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[lyrixx]

Good catch, Can you add a test case? If you can't, I'll, not problem

[fabpot]

Thank you @adpauly.