[Scheduler] Add DateIntervalTrigger and DatePeriodTrigger #49739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
scheduler-simplification
branch
2 times, most recently
from
89af9e9
to
ea3f6d3
Compare
Maybe not. |
fabpot
force-pushed
the
scheduler-simplification
branch
from
ea3f6d3
to
1fe329d
Compare
|
I've removed |
fabpot
force-pushed
the
scheduler-simplification
branch
from
1fe329d
to
6844a3a
Compare
src/Symfony/Component/Scheduler/Trigger/DateIntervalTrigger.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/DateIntervalTrigger.php
Outdated
Show resolved
Hide resolved
fabpot
force-pushed
the
scheduler-simplification
branch
from
6844a3a
to
c0816e3
Compare
nicolas-grekas
approved these changes
Mar 20, 2023
fabpot
force-pushed
the
scheduler-simplification
branch
from
c0816e3
to
9a4ee58
Compare
|
@fabpot It doesn't work in real cases. Period iterator iterates over the all time points from the begginng. For example, some create a period from "2023-03-21" on every second. At "2024-03-12" the period will iterate over 31536000 poins on every worker start. It is the reason why I wrote different version. Revert it, please. |
|
@upyx I'm on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PeriodicalTriggershould only be used for a fixed period of time that can be converted to a number of seconds.Using it for
DatePerioddoes not make sense as the number of seconds between 2 runs can differ.This PR introduces 2 new triggers that behave correctly in such cases.