[HttpClient] Fix not calling the on progress callback when canceling a MockResponse

[fancyweb]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

I want to assert that a response is canceled under certain circumstances.

My first approach was to get the info from the MockResponse I pass as the response factory to the MockHttpClient but this one is lost since a new instance is created when the request method is called.

My next approach was to wrap the MockHttpClient I pass to the class I'm testing with a TraceableHttpClient. But it doesn't work because the traced info is outdated. The problem seems to be that the on-progress callback is not called when a MockResponse is canceled.

[nicolas-grekas]

Is the callback called when a real response is canceled?
What about the "info" of the reponse? Don't they give the needed clue?

[fancyweb]

Is the callback called when a real response is canceled?

Yes.

What about the "info" of the response? Don't they give the needed clue?

No, since the original mock response reference is lost, we can't access it and get the info from it.

[fancyweb]

After retesting, it works with CurlHttpClient and not with NativeHttpClient... So it might not be the best solution.

[stof]

No, since the original mock response reference is lost, we can't access it and get the info from it.

Can you check what happens when you get the info on the MockResponse being returned by $client->request() ?

[fancyweb]

The info on the MockResponse returned by $client->request() is good but I don't have access to it.

Here's a simplified gist that highlights the problem: https://gist.github.com/fancyweb/0a54ae6293eaf02c3823e9b921cada5a

[nicolas-grekas]

Maybe we could try to reuse the $mock request if it's a MockResponse? Not as a bugfix but as an improvement? I don't know if this would be possible of not :)

[nicolas-grekas]

Good catch, thanks @fancyweb.