[Routing] Add FQCN and FQCN::method aliases when applicable #50084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Routing/Tests/Fixtures/AnnotationFixtures/InvokableMethodController.php
Show resolved
Hide resolved
src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/InvokableMethodController.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
routing/invokable-fqcn-alias
branch
from
6f19dad
to
ce17164
Compare
fancyweb
changed the title
fancyweb
commented
Apr 21, 2023
| } | ||
| } | ||
|
|
||
| if ($fqcnAlias && 1 === $collection->count()) { | ||
| $collection->addAlias($class->name, $invokeRouteName = key($collection->all())); | ||
| $collection->addAlias(sprintf('%s::__invoke', $class->name), $invokeRouteName); |
There was a problem hiding this comment.
That means we add an "FQCN::__invoke" alias for controllers like this:
#[Route(path: '/foo')]
final class FooController
{
public function __invoke():
{
}
}
nicolas-grekas
approved these changes
Apr 21, 2023
|
This does not seem to deprecate the default name though AFAICT |
|
@stof Indeed, I don't think it's worth it to deprecate the default name and Nicolas agreed after discussing it with him on Slack. |
fancyweb
force-pushed
the
routing/invokable-fqcn-alias
branch
from
ce17164
to
9fa5bae
Compare
nicolas-grekas
approved these changes
Jun 9, 2023
fabpot
approved these changes
Jun 20, 2023
|
Thank you @fancyweb. |
This was referenced Oct 21, 2023
Merged
Merged
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49981, I think it's a great idea 馃槂
__invokemethod that adds a route AND if the target class added 1 route exactly.