[TwigBridge] Add FormLayoutTestCase class
#50127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
issue-49775
branch
2 times, most recently
from
9d9c580
to
c7275b9
Compare
ker0x
commented
Apr 23, 2023
| @@ -61,46 +60,6 @@ protected function tearDown(): void | |||
| parent::tearDown(); | |||
| } | |||
|
|
|||
| protected function assertXpathNodeValue(\DOMElement $element, $expression, $nodeValue) | |||
There was a problem hiding this comment.
I removed this method because it was never used
|
Failing test seems to be unrelated with these changes! |
fabpot
approved these changes
Oct 1, 2023
|
@ker0x Can you rebase on current 6.4 and resolve the conflict? Thank you. |
|
@fabpot It's done. |
|
Thank you @ker0x. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would require #50126 to be merged before!