[Notifier] Added redlink notifier #50170
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
plotkabytes
force-pushed
the
redlink-notifier
branch
from
5e46f19
to
032a4d5
Compare
|
|
||
| where: | ||
|
|
||
| - `API_TOKEN` is your user API token, you can get it from user dashboard |
There was a problem hiding this comment.
| - `API_TOKEN` is your user API token, you can get it from user dashboard | |
| - `API_TOKEN` is your user API token, you can get it from the user dashboard |
| protected const HOST = 'api.redlink.pl'; | ||
|
|
||
| public function __construct( | ||
| #[\SensitiveParameter] private readonly string $apiToken, |
There was a problem hiding this comment.
| #[\SensitiveParameter] private readonly string $apiToken, | |
| #[\SensitiveParameter] | |
| private readonly string $apiToken, |
|
|
||
| public function __construct( | ||
| #[\SensitiveParameter] private readonly string $apiToken, | ||
| #[\SensitiveParameter] private readonly string $appToken, |
There was a problem hiding this comment.
| #[\SensitiveParameter] private readonly string $appToken, | |
| #[\SensitiveParameter] | |
| private readonly string $appToken, |
| { | ||
| return sprintf( | ||
| 'redlink://%s:%s@%s?from=%s&version=%s', | ||
| $this->apiToken, |
| return sprintf( | ||
| 'redlink://%s:%s@%s?from=%s&version=%s', | ||
| $this->apiToken, | ||
| $this->appToken, |
| "require": { | ||
| "php": ">=8.1", | ||
| "symfony/http-client": "^5.4|^6.0", | ||
| "symfony/notifier": "^6.2.7" |
There was a problem hiding this comment.
| "symfony/notifier": "^6.2.7" | |
| "symfony/notifier": "^6.3" |
|
Can you please open a PR on the Symfony docs and the symfony/recipes repository? Thanks |
|
Why did you close the PR? |
Sorry, this was by mistake. I made suggested changes, and I will open PR on the Symfony docs and the symfony/recipes repository soon. Thanks! |
|
Done.
|
|
Thank you @plotkabytes. |
This PR was submitted for the 6.3 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- Add Redlink docs Documentation for new redlink notifier. PR: [symfony/symfony#50170](symfony/symfony#50170). Commits ------- 9b9cd36 Add Redlink docs
Added Redlink notifier bridge