Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Adds assertEmailSubjectContains and assertEmailSubjectNotContains methods #50200

Merged
merged 1 commit into from Jul 9, 2023
Merged

[Mailer] Adds assertEmailSubjectContains and assertEmailSubjectNotContains methods #50200

merged 1 commit into from Jul 9, 2023

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented May 1, 2023 •
edited

Adds assertEmailSubjectContains and assertEmailSubjectNotContains

Q A
Branch? 5.4
Bug fix? No
New feature? yes
Deprecations? No
Tickets Fix #49939
License MIT
Doc PR symfony/symfony-docs#18269

@carsonbot carsonbot added this to the 5.4 milestone May 1, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.3 for features / 5.4 or 6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@johanadivare
Copy link
Contributor

Sorry the labels are incorrect as i posted the pull request before updating the default message.

@JohJohan JohJohan force-pushed the 49939 branch 3 times, most recently from 6508101 to 77eacd9 Compare May 1, 2023 11:28
@OskarStark
Copy link
Contributor

Please rebase on 6.3 branch, we can merge this later in 6.4 once the branch is created. Thanks

@JohJohan JohJohan changed the base branch from 5.4 to 6.3 May 2, 2023 06:49
@JohJohan
Copy link
Contributor Author

JohJohan commented May 2, 2023

Please rebase on 6.3 branch, we can merge this later in 6.4 once the branch is created. Thanks

Okay will do why can i not target 5.4 as this is still maintained branch? https://symfony.com/doc/current/contributing/code/pull_requests.html#choose-the-right-branch or is it because this is seen as new feature?

@OskarStark
Copy link
Contributor

Exactly, this is a new feature and must target the latest branch 👍

@OskarStark OskarStark mentioned this pull request May 2, 2023
Merged
ndench
ndench approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OskarStark OskarStark modified the milestones: 5.4, 6.4 Jun 12, 2023
@JohJohan JohJohan force-pushed the 49939 branch 2 times, most recently from d6c20c1 to a5bd838 Compare June 12, 2023 07:49
@OskarStark OskarStark changed the title [Mailer] Adds assertEmailSubjectContains and assertEmailSubjectNotContains [Mailer] Adds assertEmailSubjectContains and assertEmailSubjectNotContains methods Jun 12, 2023
@johanadivare
[Mailer] Add EmailSubjectContains constraint (symfony#49939)
55ba7b8 
Adds assertEmailSubjectContains and assertEmailSubjectNotContains
@fabpot
Copy link
Member

fabpot commented Jul 9, 2023

Thank you @JohJohan.

@fabpot fabpot merged commit f143f34 into symfony:6.4 Jul 9, 2023
5 of 9 checks passed
@JohJohan JohJohan deleted the 49939 branch July 9, 2023 08:15
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jul 12, 2023
@javiereguiluz
minor #18269 [Mailer] Add new email testing functions (johanadivare)
75c3270 
This PR was merged into the 6.4 branch.

Discussion
----------

[Mailer] Add new email testing functions

Refs symfony/symfony#50200

Commits
-------

1904ba2 [Mailer] Add new email testing functions (fixes #50200)
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@ndench ndench ndench approved these changes

Assignees
No one assigned
Labels
Bug Deprecation Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

Create EmailSubjectContains constraint for emails
6 participants
@JohJohan @carsonbot @johanadivare @OskarStark @fabpot @ndench