[Security] Make PersistentToken immutable and tell TokenProviderInterface::updateToken() implementations should accept DateTimeInterface
#50290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
May 10, 2023
•
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of #47580 |
| License | MIT |
| Doc PR | - |
ro0NL
reviewed
May 10, 2023
src/Symfony/Component/Security/Core/Authentication/RememberMe/PersistentToken.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
sec-immut
branch
2 times, most recently
from
a6d57c7
to
946043a
Compare
src/Symfony/Component/Scheduler/Trigger/CronExpressionTrigger.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
sec-immut
branch
2 times, most recently
from
7e70a3a
to
216d89c
Compare
|
PR rebased and ready for merge in 6.3 if desired. |
|
PR ready for 6.3. |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2023
This PR was merged into the 6.4 branch. Discussion ---------- Remove unnecessary usages of DateTime | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #47580 | License | MIT | Doc PR | - Together with #50290, this PR removes `DateTime` everywhere possible. What remains is: - test cases that test both DateTime and DateTimeImmutable - legit to keep - date/time form-types and transformers in the Form component - we'd need a separate effort for them, related to #50295 - `PersistentTokenInterface::getLastUsed(): \DateTime` - separate effort also Commits ------- 8b08294 Remove unnecessary usages of DateTime
|
@nicolas-grekas This PR should be adapted for 6.4 instead of 6.3. |
|
PR updated, ready for 6.4 |
nicolas-grekas
force-pushed
the
sec-immut
branch
2 times, most recently
from
8091528
to
7e7f384
Compare
|
The low deps failures are related, aren't they? |
Right, fixed! |
…terface::updateToken()` implementations should accept `DateTimeInterface`
nicolas-grekas
force-pushed
the
sec-immut
branch
from
7700d67
to
3df345c
Compare
fabpot
approved these changes
Jul 13, 2023
|
Thank you @nicolas-grekas. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.