Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] Add AppVariable::getEnabledLocales() #50321

Merged
merged 1 commit into from Oct 1, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented May 15, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR symfony/symfony-docs#...

This PR aims to provide a new app.enabled_locales getter for templates to retrieve the enabled locales configured using the framework.enabled_locales configuration, to make e.g. a locale switcher in the templates without to have to pass the enabled locales using e.g. a Twig global.

The docs PR will me made if the PR is accepted.

Targeting the 6.3 branch for now, will switch to 6.4 when it will be available (as feature freeze is active since late March).

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@jmsche
Copy link
Contributor Author

jmsche commented May 15, 2023

CI failures seem unrelated.

@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@fabpot
Copy link
Member

fabpot commented Oct 1, 2023

Thank you @jmsche.

@fabpot fabpot force-pushed the feature/twig-enabled-locales branch from f4f39d2 to 3e1925c Compare October 1, 2023 16:37
@fabpot fabpot merged commit 73a3f78 into symfony:6.4 Oct 1, 2023
3 of 7 checks passed
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants