[FrameworkBundle][PropertyInfo] Wire the ConstructorExtractor class
#50334
+74
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
wire-constructorextractor
branch
2 times, most recently
from
a50e8c9
to
5261db6
Compare
HypeMC
force-pushed
the
wire-constructorextractor
branch
from
5261db6
to
b68f40e
Compare
HypeMC
force-pushed
the
wire-constructorextractor
branch
from
b68f40e
to
711cbbd
Compare
HypeMC
force-pushed
the
wire-constructorextractor
branch
3 times, most recently
from
da9d4fb
to
03922ec
Compare
HypeMC
force-pushed
the
wire-constructorextractor
branch
from
03922ec
to
a02c6f1
Compare
HypeMC
force-pushed
the
wire-constructorextractor
branch
from
a02c6f1
to
796dcc2
Compare
|
What is the status of this PR ? It would be nice to see this in 7.1. |
HypeMC
force-pushed
the
wire-constructorextractor
branch
from
796dcc2
to
d2fcfbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sort of followup to #30335.
The original PR removed the wiring to prevent creating a BC break, see #30128 (comment) & #30335 (comment).
This PR proposes adding a new
framework.property_info.with_constructor_extractorconfiguration to allow optionally enabling the framework integration. The configuration defaults tofalseto prevent creating a BC break. Only when it's set totruewill theConstructorExtractorbe registered in the container.