[WebProfilerBundle] Fix cursor on link that has no href

[PhilETaylor]

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

A a link tag with no href has the wrong cursor icon by default when hovering it. Eg: https://codepen.io/philetaylor/pen/mdzQoxR

Before

before.mov

anotherbefore.mov

After

after.mov

[nicolas-grekas]

Won't this break CSP rules?

[PhilETaylor]

It doesn't appear to.

[nicolas-grekas]

Thank you @PhilETaylor.

[stof]

The right markup for this would be a <button type="button"> (with the appropriate CSS to make it look like a textual link). A <a> without href is neither interactive nor focusable, so this would be an accessibility issue.

@nicolas-grekas there is no CSP at all on profiler pages (our toolbar has to avoid CSP issues as it gets injected into the project pages)

[PhilETaylor]

The right markup for this would be a

I did type that out, but deleted it, sorry, was in the car earlier. I guess we need to revert this one, or revert it with a new PR, where would the css go?

[PhilETaylor]

As a button, with no css, it also doesn't have a pointer.

Screen.Recording.2023-05-22.at.15.06.05.mov

[PhilETaylor]

Markup:
line <button type="button" class="text-small sf-toggle sf-toggle-button" data-toggle-selector="#sf-trace-{{ loop.index0 }}">{{ caller.line }}</button> (<button type="button" class="text-small sf-toggle sf-toggle-button" data-toggle-selector="#sf-context-{{ loop.index0 }}">context</button>):

With new css in profiler.css.twig

.sf-toggle-button {
    background: none!important;
    border: none;
    padding: 0!important;
    color: rgb(29, 78, 216);
    cursor: pointer;
}

Looks like this - if this is ok I can PR this:

Screen.Recording.2023-05-22.at.15.10.28.mov

ok?

[PhilETaylor]

converted to a button in PR #50386