Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Add peekMultiple method to FlashBag #50380

Open
wants to merge 2 commits into
base: 7.1
Choose a base branch
from

Conversation

alexmerlin
Copy link

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #49659
License MIT
Doc PR -

This PR adds the peekMultiple method to FlashBag and AutoExpireFlashBag, as requested in #49659.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@carsonbot carsonbot added this to the 6.3 milestone May 21, 2023
@derrabus derrabus changed the title [FlashBag] Add peekMultiple method Add peekMultiple method to FlashBag May 21, 2023
@carsonbot carsonbot changed the title Add peekMultiple method to FlashBag [HttpFoundation] Add peekMultiple method to FlashBag May 21, 2023
@alexmerlin
Copy link
Author

Hey @derrabus, thank you for looking into this PR.
Do you have any insight on what should I fix in order to go green with the tests?
From what I see, the tests did not fail, it's just an error that the Process completed with exit code 1.

@andreybolonin
Copy link

@alexmerlin As I understand 6.2 is feature freeze stage and no adding new features
You should change 6.3 to 6.4 after 31 may

@derrabus
Copy link
Member

Do you have any insight on what should I fix in order to go green with the tests?

I don't think that the failure is related to your changes. You can ignore the red unit tests.

@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlashBag peekMultiple() method
5 participants