[RemoteEvent][Webhook] Add Mailjet support #50502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blaugueux
commented
May 31, 2023
blaugueux
commented
| Q | A |
|---|---|
| Branch | 6.4 |
| Bug fix | no |
| New feature | yes |
| Deprecations | no |
| Tickets | |
| License | MIT |
| Doc PR |
carsonbot
changed the title
blaugueux
changed the title
fabpot
approved these changes
May 31, 2023
src/Symfony/Component/Mailer/Bridge/Mailjet/RemoteEvent/MailjetPayloadConverter.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Jun 3, 2023
There was a problem hiding this comment.
@blaugueux You need to add "symfony/webhook": "^6.3" in the require-dev section of the Mailjet bridge composer.json file to make tests pass.
|
@blaugueux Can you rebase to see if the tests would pass? |
OskarStark
reviewed
Aug 3, 2023
fabpot
approved these changes
Aug 4, 2023
|
Thank you @blaugueux. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.