Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecurityBundle] Fix error message when using OIDC and web-token/jwt-core is not installed #50503

Merged
merged 1 commit into from May 31, 2023
Merged

[SecurityBundle] Fix error message when using OIDC and web-token/jwt-core is not installed #50503

merged 1 commit into from May 31, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 31, 2023 •
edited

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50491
License MIT
Doc PR -

Before:

Service "security.access_token_handler.oidc.signature.ES256": Cannot replace arguments for class "Jose\Component\Signature\Algorithm\ES256" if none have been configured yet.

After:

You cannot use the "oidc" token handler since "web-token/jwt-core" is not installed. Try running "composer require web-token/jwt-core".

/cc @vincentchalamon

@carsonbot carsonbot added this to the 6.3 milestone May 31, 2023
@nicolas-grekas nicolas-grekas merged commit 99e1b1f into symfony:6.3 May 31, 2023
5 of 9 checks passed
@chalasr
Copy link
Member

chalasr commented May 31, 2023

nice catch

@nicolas-grekas nicolas-grekas deleted the oidc-fix branch May 31, 2023 12:47
@fabpot fabpot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolas-grekas @chalasr @carsonbot