[RemoteEvent][Webhook] Add Sendinblue support #50516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blaugueux
commented
May 31, 2023
blaugueux
commented
| Q | A |
|---|---|
| Branch | 6.4 |
| Bug fix | no |
| New feature | yes |
| Deprecations | no |
| Tickets | |
| License | MIT |
| Doc PR |
OskarStark
reviewed
Jun 4, 2023
OskarStark
reviewed
Jun 4, 2023
src/Symfony/Component/Mailer/Bridge/Sendinblue/Webhook/SendinblueRequestParser.php
Outdated
Show resolved
Hide resolved
|
@OskarStark Can you please tell me if I need to work on something on this PR? |
|
Looks good from my side, WDYT @fabpot ? |
|
Given that Sendinblue has rebranded as Brevo and there is an in-progress PR to create a Brevo bridge using the new domain, I would vote -1 for this PR in its current state. The webhook and remote event integrations should be added to the new bridge, not to the old one. |
|
@blaugueux Can you work on adding this to the new bridges? |
|
@fabpot of course. Just give me few days! |
|
Thank you, let's close here then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.