[Console] Add placeholders to ProgressBar for exact times #50537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeckers
force-pushed
the
patch_49927_console_remaining_time
branch
3 times, most recently
from
1eecd3b
to
82a1c62
Compare
OskarStark
reviewed
Jun 17, 2023
|
I think we can simplify this to just replace the existing |
maxbeckers
force-pushed
the
patch_49927_console_remaining_time
branch
from
82a1c62
to
c0ca8f9
Compare
|
Thanks @wouterj and @OskarStark for your input. I now changed it. |
OskarStark
added
the
❄️ Feature Freeze
GromNaN
reviewed
Oct 9, 2023
maxbeckers
force-pushed
the
patch_49927_console_remaining_time
branch
from
c0ca8f9
to
190f835
Compare
maxbeckers
force-pushed
the
patch_49927_console_remaining_time
branch
from
190f835
to
b553dd9
Compare
OskarStark
approved these changes
Oct 9, 2023
GromNaN
approved these changes
Oct 9, 2023
OskarStark
changed the title
fabpot
approved these changes
Oct 10, 2023
|
Thank you @maxbeckers. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for exact times using ProgressBar based on the idea of @GromNaN in the issue #49927.
Open to discuss this first way of implementing it.
I'll create the docs PR when the feature is agreed and there won't come up any bigger changes.
The Idea is to show the exact time in seconds, the ProgressBar will run / is running.