Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer][Webhook] Add Sendgrid webhook support #50705

Merged
merged 1 commit into from Aug 30, 2023
Merged

[Mailer][Webhook] Add Sendgrid webhook support #50705

merged 1 commit into from Aug 30, 2023

Conversation

WoutervanderLoopNL
Copy link
Contributor

@WoutervanderLoopNL WoutervanderLoopNL commented Jun 19, 2023 •
edited by OskarStark

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #50704
License MIT

Support webhooks from SendGrid

@carsonbot carsonbot added this to the 6.4 milestone Jun 19, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Webhook][RemoteEvent] Add Sendgrid symfony/symfony#50704 [RemoteEvent][Webhook] Add Sendgrid symfony/symfony#50704 Jun 19, 2023
@WoutervanderLoopNL WoutervanderLoopNL force-pushed the webhook-sendgrid branch 3 times, most recently from 8ceee75 to 1728999 Compare June 21, 2023 11:26
@OskarStark OskarStark changed the title [RemoteEvent][Webhook] Add Sendgrid symfony/symfony#50704 [RemoteEvent][Webhook] Add Sendgrid Jun 26, 2023
@carsonbot carsonbot changed the title [RemoteEvent][Webhook] Add Sendgrid [Mailer][Webhook] Add Sendgrid Jul 14, 2023
@derrabus derrabus changed the title [Mailer][Webhook] Add Sendgrid [Mailer] Add Sendgrid webhook support Jul 14, 2023
@carsonbot carsonbot changed the title [Mailer] Add Sendgrid webhook support [Mailer][Webhook] Add Sendgrid webhook support Aug 16, 2023
@WoutervanderLoopNL WoutervanderLoopNL force-pushed the webhook-sendgrid branch 2 times, most recently from c9a9897 to ba7d5af Compare August 16, 2023 09:30
@WoutervanderLoopNL WoutervanderLoopNL mentioned this pull request Aug 17, 2023
Closed
@WoutervanderLoopNL WoutervanderLoopNL force-pushed the webhook-sendgrid branch 3 times, most recently from dacde4d to 81ade8c Compare August 18, 2023 10:59
stof
stof reviewed Aug 18, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@WoutervanderLoopNL WoutervanderLoopNL force-pushed the webhook-sendgrid branch 2 times, most recently from 3806598 to eb6d0b8 Compare August 18, 2023 11:15
@WoutervanderLoopNL WoutervanderLoopNL force-pushed the webhook-sendgrid branch 2 times, most recently from cb81fe0 to a119107 Compare August 18, 2023 11:53
@fabpot
Copy link
Member

fabpot commented Aug 30, 2023

Thank you @WoutervanderLoopNL.

@fabpot fabpot merged commit b1a7024 into symfony:6.4 Aug 30, 2023
6 of 9 checks passed
@fabpot fabpot mentioned this pull request Aug 30, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

@SherinBloemendaal SherinBloemendaal Awaiting requested review from SherinBloemendaal

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed Webhook
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Webhook][RemoteEvent] Add Sendgrid
8 participants
@WoutervanderLoopNL @carsonbot @smnandre @fabpot @stof @OskarStark @SherinBloemendaal @derrabus