Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] Allow to change element for form_help block #50770

Merged
merged 1 commit into from Jul 3, 2023

Conversation

seb-jean
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Currently, the element for the block form_help is a div. With this feature, we are free to change it

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we already have this for form_label)

@nicolas-grekas
Copy link
Member

(but please check the other form templates so that we allow this for all of them)

@seb-jean
Copy link
Contributor Author

I checked the other form templates and found no problems.

@nicolas-grekas
Copy link
Member

Thank you @seb-jean.

@nicolas-grekas nicolas-grekas merged commit 6178664 into symfony:6.4 Jul 3, 2023
8 of 9 checks passed
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants