[EventDispatcher] Improve method resolving when event is omitted in tag #50777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Jun 26, 2023
| || !($r = $container->getReflectionClass($class, false)) | ||
| || 1 !== count($publicMethods = $r->getMethods(\ReflectionMethod::IS_PUBLIC)) | ||
| ) { | ||
| return '__invoke'; |
There was a problem hiding this comment.
I kept this for BC, but I'm wondering if an exception should not be thrown here 🤔
nikophil
force-pushed
the
feat/improve-method-resolving
branch
from
1846724
to
3a59207
Compare
kbond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if both event and method names are omitted in the listener's tag, we automatically fallback on
__invokemaybe we can check if a unique public method exists, and then fallback on it?
(not sure if this should be considered as a bugfix or new feature...)
ping @GromNaN