Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Fix Inflector for 'status' #50810

Merged
merged 1 commit into from Jun 28, 2023

Conversation

evertharmeling
Copy link
Contributor

@evertharmeling evertharmeling commented Jun 28, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50805
License MIT
Doc PR n/a

Although different sources prefer status over statuses as the plural (or the other way around), not sure if it matters much in preference for the codebase.

@javiereguiluz
Copy link
Member

Google Ngram Viewer also shows that the usage of statuses is residual compared to status:

https://books.google.com/ngrams/graph?content=status%2Cstatuses&year_start=1800&year_end=2019&corpus=en-US-2019&smoothing=3

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nicolas-grekas
Copy link
Member

Thank you @evertharmeling.

@nicolas-grekas nicolas-grekas merged commit 6d52175 into symfony:5.4 Jun 28, 2023
9 of 11 checks passed
This was referenced Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants