[Components] Convert to native return types #50852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jul 2, 2023
•
wouterj
commented
| Q | A |
|---|---|
| Branch? | 7.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
wouterj
requested review from
lyrixx,
chalasr,
dunglas,
yceruto,
jderusse and
xabbuh
as code owners
|
rebase unlocked + some fixes needed I guess |
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
convert-to-native-types-2
branch
from
e3220b5
to
824f48a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 5, 2023
…ribedEvents()` (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [Security] Add native return type to `Firewall::getSubscribedEvents()` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Required to make #50852 green without breaking compat between v6 and v7. Commits ------- 8069f49 [Security] Add native return type to `Firewall::getSubscribedEvents()`
nicolas-grekas
force-pushed
the
convert-to-native-types-2
branch
from
824f48a
to
a250774
Compare
nicolas-grekas
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
I finished the PR.
I order to help third party bundles to be compatible with Symfony 7, I didn't add the void return type to the following interfaces (all listed in .github/expected-missing-return-types.diff):
- src/Symfony/Component/DependencyInjection/Compiler/CompilerPassInterface.php
- src/Symfony/Component/DependencyInjection/Extension/PrependExtensionInterface.php
- src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php
Please open an issue or send a PR if you think we should add more interfaces to this list.
Note that src/Symfony/Contracts/Service/ResetInterface.php also doesn't have a native type, and that's on purpose, to keep compatibility with implementations that do have a return value.
I also patched DebugClassLoader so that it doesn't skip void return types.
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.