[Security] Remove deprecated code paths #50866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
sec-deprec
branch
2 times, most recently
from
58e0b57
to
62756fb
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 4, 2023
…her cleanups (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [SecurityBundle] Deprecate `Security::*` consts and other cleanups | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Required to make #50866 green without breaking compat with v7 Commits ------- 5cc0e1c [SecurityBundle] Deprecate `Security::*` consts and other cleanups
nicolas-grekas
force-pushed
the
sec-deprec
branch
from
62756fb
to
d66a550
Compare
nicolas-grekas
force-pushed
the
sec-deprec
branch
from
d66a550
to
a3a3856
Compare
Merged
tcitworld
added a commit
to tcitworld/symfony
that referenced
this pull request
Jan 12, 2024
In SF 7.0, the deprecated {username} placeholder was removed in favor of {user_identifier} (in symfony#50866).
However, the default values for the filter and dn_string parameters still contained {username} instead of the updated key.
This PR changes the value to the new updated key
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
xabbuh
added a commit
that referenced
this pull request
Jan 13, 2024
…pgrade guide (W0rma) This PR was merged into the 7.0 branch. Discussion ---------- [SecurityBundle] Add missing removed config options to upgrade guide | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Seems like some entries added in #50866 from got lost from the upgrade guide. Commits ------- 8c63772 [SecurityBundle] Add missing removed config options to upgrade guide
fabpot
added a commit
that referenced
this pull request
Jan 18, 2024
…` in factories (tcitworld)
This PR was merged into the 7.0 branch.
Discussion
----------
[Ldap] Use `{user_identifier}` over deprecated `{username}` in factories
| Q | A
| ------------- | ---
| Branch? | 7.0
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues |
| License | MIT
In SF 7.0, the deprecated `{username}` placeholder was removed in favor of `{user_identifier}` (in #50866). However, the default values for the `filter` and `dn_string` parameters still contained `{username}` instead of the updated key.
This PR changes the value to the new updated key
Commits
-------
30baf82 fix(ldap): replace {username} with {user_identifier} in LDAP factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_authenticator_managerandcsrf_token_generator{username}parameter, use{user_identifier}instead