Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Support APP_BUILD_DIR #50951

Merged
merged 1 commit into from Aug 4, 2023
Merged

[FrameworkBundle] Support APP_BUILD_DIR #50951

merged 1 commit into from Aug 4, 2023

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jul 12, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

follows APP_CACHE_DIR

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4, 6.2, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 13, 2023

in github CI we want to persist the build dir, but not the cache dir + log dir, eg.

if [[ "${CI}" = true ]]; then
    export APP_BUILD_DIR=/app/var/sf-cache
    export APP_CACHE_DIR=/tmp/app-cache
    export APP_LOG_DIR=/tmp/app-logs
fi

@fabpot
Copy link
Member

fabpot commented Aug 4, 2023

Thank you @ro0NL.

@fabpot fabpot merged commit 0a9ef56 into symfony:6.4 Aug 4, 2023
3 of 9 checks passed
@ro0NL ro0NL deleted the patch-1 branch August 4, 2023 09:18
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants