Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ErrorHandler][Runtime] Don't mess with ini_set('assert.warning') #50994

Merged
merged 1 commit into from Jul 16, 2023
Merged

[ErrorHandler][Runtime] Don't mess with ini_set('assert.warning') #50994

merged 1 commit into from Jul 16, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

From https://wiki.php.net/rfc/assert-string-eval-cleanup#assertwarning:

As of PHP 7, this setting only has an effect if assert.exception is disabled

@carsonbot carsonbot added this to the 5.4 milestone Jul 16, 2023
@carsonbot carsonbot changed the title [Runtime][ErrorHandler] Don't mess with ini_set('assert.warning') [ErrorHandler][Runtime] Don't mess with ini_set('assert.warning') Jul 16, 2023
@nicolas-grekas nicolas-grekas force-pushed the assert.warn branch 3 times, most recently from 838ecb6 to db8b86b Compare July 16, 2023 16:44
@nicolas-grekas nicolas-grekas merged commit 0c1e73e into symfony:5.4 Jul 16, 2023
10 of 11 checks passed
@nicolas-grekas nicolas-grekas deleted the assert.warn branch July 25, 2023 15:45
This was referenced Jul 29, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug ErrorHandler Runtime Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolas-grekas @carsonbot