Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer] Add Scaleway bridge #51014

Merged
merged 1 commit into from Jul 30, 2023
Merged

[Mailer] Add Scaleway bridge #51014

merged 1 commit into from Jul 30, 2023

Conversation

MrMicky-FR
Copy link
Contributor

@MrMicky-FR MrMicky-FR commented Jul 18, 2023 •
edited

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#18581

This PR adds a new mailer bridge for Scaleway Transactional Emails.

I've been using this bridge in production for several months, with thousands of emails sent, and everything works perfectly 馃殌

@carsonbot carsonbot added this to the 6.4 milestone Jul 18, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@javiereguiluz javiereguiluz mentioned this pull request Jul 18, 2023
Merged
@OskarStark OskarStark requested a review from fabpot July 23, 2023 20:06
@MrMicky-FR
Copy link
Contributor Author

Thanks for your feedback, I've committed the changes

@fabpot
Copy link
Member

fabpot commented Jul 30, 2023

Thank you @MrMicky-FR.

@fabpot fabpot merged commit 767a7ef into symfony:6.4 Jul 30, 2023
6 of 9 checks passed
@fabpot
Copy link
Member

fabpot commented Jul 30, 2023

@MrMicky-FR Can you submit a PR on symfony/recipes for this mailer?

@MrMicky-FR MrMicky-FR deleted the scaleway_mailer branch July 30, 2023 17:13
@MrMicky-FR MrMicky-FR mentioned this pull request Jul 30, 2023
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Jul 31, 2023
@OskarStark
feature #18581 [Mailer] Add Scaleway bridge documentation (MrMicky-FR)
c3a449d 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Mailer] Add Scaleway bridge documentation

This PR adds documentation for
* symfony/symfony#51014

Commits
-------

cdf8811 [Mailer] Add Scaleway bridge documentation
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrMicky-FR @carsonbot @fabpot @OskarStark @derrabus