[Intl] Add support for ISO 3166-1 numeric codes #51073
Conversation
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "5.4". Cheers! Carsonbot |
| 'ZW' => '716', | ||
| 'ZZ' => '999', | ||
| ], | ||
| 'NumericToAlpha2' => [ |
There was a problem hiding this comment.
Not sure the best way to handle these numeric strings with leading zeros as array keys - we have a mix of int and string keys.
There was a problem hiding this comment.
perhaps sanitize all to string?
| 'ZW' => '716', | ||
| 'ZZ' => '999', | ||
| ], | ||
| 'NumericToAlpha2' => [ |
There was a problem hiding this comment.
perhaps sanitize all to string?
| 964 => 'QR', | ||
| 965 => 'QS', | ||
| 966 => 'QT', | ||
| 'QV', |
There was a problem hiding this comment.
I've forced all the array keys to be numeric strings, prefixed with an underscore, to stop PHP trying to convert string numbers such as '077' to (int) 77.
benr77
force-pushed
the
add-iso-3166-1-numeric
branch
3 times, most recently
from
09deecd
to
cde4f83
Compare
benr77
force-pushed
the
add-iso-3166-1-numeric
branch
2 times, most recently
from
ff2b253
to
d2cbeb5
Compare
|
Unit test failures appear to be unrelated to the PR. |
benr77
force-pushed
the
add-iso-3166-1-numeric
branch
from
d2cbeb5
to
9c071c6
Compare
benr77
force-pushed
the
add-iso-3166-1-numeric
branch
from
9c071c6
to
f93a3c8
Compare
benr77
force-pushed
the
add-iso-3166-1-numeric
branch
from
f93a3c8
to
972acf2
Compare
|
Thank you @benr77. |
…nr77) This PR was merged into the 6.4 branch. Discussion ---------- [Intl] Document support for ISO 3166-1 numeric codes To accompany PR * symfony/symfony#51073 Commits ------- a9da7e0 Document support for ISO 3166-1 numeric codes
Add support for ISO-3166-1 numeric codes.
As well as the existing Alpha2 and Alpha3 codes, this PR adds support for the numeric country codes as per https://www.iso.org/obp/ui/#search/code/.