[FrameworkBundle] Enable json_decode_detailed_errors in dev by default
#51215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 2, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
ostrolucky
force-pushed
the
auto-enable-json-detailed-errors
branch
4 times, most recently
from
2a551c2
to
4939f03
Compare
ostrolucky
force-pushed
the
auto-enable-json-detailed-errors
branch
from
4939f03
to
b595e90
Compare
nicolas-grekas
approved these changes
Aug 2, 2023
fabpot
approved these changes
Aug 3, 2023
|
Thank you @ostrolucky. |
This was referenced Oct 21, 2023
Merged
Merged
stof
reviewed
Nov 14, 2023
| @@ -1123,6 +1125,10 @@ private function addSerializerSection(ArrayNodeDefinition $rootNode, callable $e | |||
| ->arrayNode('default_context') | |||
| ->normalizeKeys(false) | |||
| ->useAttributeAsKey('name') | |||
| ->beforeNormalization() | |||
There was a problem hiding this comment.
Adding that default in beforeNormalization makes it very hard to re-disable the feature because each source will re-enable it in this normalization (well, each source configuring the default_context).
This should be done in the validate phase instead.
| ->beforeNormalization() | ||
| ->ifTrue(fn () => $this->debug && class_exists(JsonParser::class)) | ||
| ->then(fn (array $v) => $v + [JsonDecode::DETAILED_ERROR_MESSAGES => true]) | ||
| ->end() | ||
| ->defaultValue([]) |
There was a problem hiding this comment.
the default value should probably also include JsonDecode::DETAILED_ERROR_MESSAGES => true (when appropriate) so that this configuration also applies when no default_context is configured at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows