[Workflow] Add a TraceableWorkflow
#51220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Aug 2, 2023
94noni
reviewed
Aug 2, 2023
OskarStark
changed the title
TraceableWorkflow
lyrixx
force-pushed
the
workflow-traceable
branch
from
b8e51a2
to
ae24365
Compare
94noni
reviewed
Aug 2, 2023
94noni
reviewed
Aug 3, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/WorkflowDebugPass.php
Outdated
Show resolved
Hide resolved
94noni
approved these changes
Aug 3, 2023
lyrixx
force-pushed
the
workflow-traceable
branch
from
ae24365
to
6aa12ed
Compare
carsonbot
changed the title
TraceableWorkflowTraceableWorkflow
|
This PR is ready for 2 month. I'm gonna merge it by the end of the week if there are not more review |
fabpot
changed the title
TraceableWorkflowTraceableWorkflow
fabpot
reviewed
Oct 11, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/WorkflowDebugPass.php
Outdated
Show resolved
Hide resolved
|
@lyrixx Last call for 6.4 :) |
stof
reviewed
Oct 18, 2023
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
workflow-traceable
branch
2 times, most recently
from
0c7dc40
to
750aa14
Compare
lyrixx
force-pushed
the
workflow-traceable
branch
4 times, most recently
from
2d5a6ee
to
d75ea2f
Compare
stof
reviewed
Oct 19, 2023
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
workflow-traceable
branch
from
d75ea2f
to
023078b
Compare
lyrixx
force-pushed
the
workflow-traceable
branch
from
023078b
to
963cc7a
Compare
fabpot
approved these changes
Oct 20, 2023
|
Thank you @lyrixx. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I wanted to display the current marking on the graph, but it's not possible. "current" does not mean anything. What if I use the workflow for 2 entities? What if I call twice
apply(). Which marking should I choose? => this is not possible.But, DoctrineBundle use ajax, like for explaining SQL request. It would be nice to be able to click on a marking, and it'll re-render the graph with this marking. WDYT?