[Notifier] Add GoIP bridge #51349
Closed
[Notifier] Add GoIP bridge #51349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 11, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/GoIP/GoIPTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/GoIP/GoIPTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/GoIP/GoIPTransportFactory.php
Outdated
Show resolved
Hide resolved
This was referenced Aug 11, 2023
OskarStark
requested changes
Aug 12, 2023
OskarStark
approved these changes
Aug 12, 2023
|
@ahmedghanem00 Can you rebase to get rid of the merge commit? |
ahmedghanem00
force-pushed
the
feature/goip-notifier
branch
from
e9d2d40
to
8075d08
Compare
|
@fabpot I think this is done now |
fabpot
approved these changes
Aug 12, 2023
|
Thank you @ahmedghanem00. |
fabpot
force-pushed
the
feature/goip-notifier
branch
from
8075d08
to
066d0f8
Compare
fabpot
added a commit
that referenced
this pull request
Aug 12, 2023
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] Add GoIP bridge | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#18742 | Recipes | symfony/recipes#1233 GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony Notifier Commits ------- 066d0f8 [Notifier] Add GoIP bridge
|
@fabpot Thanks, Just a small wondering about why the status of the PR is closed instead of merged like others 😆 |
|
That’s a race condition in the order of the API calls. No worries, it was merged like any other PR. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 14, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] Add GoIP bridge To follow-up with symfony/symfony#51349 Commits ------- 96ebe06 [Notifier] Add GoIP bridge
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony Notifier